Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish cloud-provider-kind images #7351

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

aojea
Copy link
Member

@aojea aojea commented Sep 29, 2024

crane digest gcr.io/k8s-staging-kind/cloud-provider-kind:v20240929-43cbeb6
sha256:cacb2da53a0d3b363bf53f11c9e0f714d7605471130a43ae7d1e161da0c3cbdb

Ref: kubernetes-sigs/cloud-provider-kind#115

/assign @BenTheElder

Change-Id: I1995b78a8f7ccf0bfdb6214d38e5a3d62a013cb8
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Sep 29, 2024
@k8s-ci-robot k8s-ci-robot added area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Sep 29, 2024
@aojea
Copy link
Member Author

aojea commented Oct 7, 2024

/assign @BenTheElder @ameukam

@ameukam
Copy link
Member

ameukam commented Oct 7, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2a1a043 into kubernetes:main Oct 7, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 7, 2024
@aojea
Copy link
Member Author

aojea commented Oct 7, 2024

@ameukam what is the public url of this image?

@@ -0,0 +1,6 @@
# See the OWNERS file documentation:
# https://github.com/kubernetes/kubernetes/blob/master/docs/devel/owners.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud provider kind is a distinct subproject and should be published via it's own staging?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too late now I guess, but we should be careful about this part in the future, with immutable images we're stuck with naming and we have arbitrary nesting so we could do distinct paths for each.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... not too late

@BenTheElder
Copy link
Member

@ameukam what is the public url of this image?

nowhere. k8s-staging-kind isn't setup to publish yet, there's two sets of configs.

let's fix that by creating a k8s-staging-cloud-provider-kind and stick these there.

@BenTheElder
Copy link
Member

ideally they should wind up registry.k8s.io/cloud-provider-kind/.. and we'll leave the registry.k8s.io/kind namespace for the main project for now

also let's make sure the staging GCB project etc is isolated. we should not encourage subprojects to reuse these. adding more projects is cheap and increases isolation.

https://github.com/kubernetes/k8s.io/tree/main/registry.k8s.io#creating-image-promoter-manifests

@aojea
Copy link
Member Author

aojea commented Oct 7, 2024

ideally they should wind up registry.k8s.io/cloud-provider-kind/.. and we'll leave the registry.k8s.io/kind namespace for the main project for now

IIRC we decided to use kind because cloud-provider-kind was too long and failed

@BenTheElder
Copy link
Member

IIRC we decided to use kind because cloud-provider-kind was too long and failed

🤨

Too long where?

@aojea
Copy link
Member Author

aojea commented Nov 12, 2024

IIRC we decided to use kind because cloud-provider-kind was too long and failed

🤨

Too long where?

the size of the name bucket :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants