-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish cloud-provider-kind images #7351
Conversation
Change-Id: I1995b78a8f7ccf0bfdb6214d38e5a3d62a013cb8
/assign @BenTheElder @ameukam |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ameukam what is the public url of this image? |
@@ -0,0 +1,6 @@ | |||
# See the OWNERS file documentation: | |||
# https://github.com/kubernetes/kubernetes/blob/master/docs/devel/owners.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloud provider kind is a distinct subproject and should be published via it's own staging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too late now I guess, but we should be careful about this part in the future, with immutable images we're stuck with naming and we have arbitrary nesting so we could do distinct paths for each.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... not too late
nowhere. k8s-staging-kind isn't setup to publish yet, there's two sets of configs. let's fix that by creating a k8s-staging-cloud-provider-kind and stick these there. |
ideally they should wind up also let's make sure the staging GCB project etc is isolated. we should not encourage subprojects to reuse these. adding more projects is cheap and increases isolation. |
IIRC we decided to use kind because cloud-provider-kind was too long and failed |
🤨 Too long where? |
the size of the name bucket :) |
Ref: kubernetes-sigs/cloud-provider-kind#115
/assign @BenTheElder