Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepared slack-infra registry namespace #802

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Prepared slack-infra registry namespace #802

merged 1 commit into from
Apr 30, 2020

Conversation

bartsmykla
Copy link
Contributor

When deployed slack-infra to the aaa I realized we can't use existing slack-tools images:

Warning  Failed     16s (x2 over 30s)  kubelet, gke-aaa-pool2-20200316195138785800000-fafa121a-zhw5  Failed to pull image "gcr.io/kubernetes-tools/slackin-kubernetes@sha256:d1a9b02239e690d5cbd78c76475a112aedf279dbd8ef401de1b8394f817a23b3": rpc error: code = Unknown desc = Error response from daemon: pull access denied for gcr.io/kubernetes-tools/slackin-kubernetes, repository does not exist or may require 'docker login'

so this PR is intended to prepare "namespace" for slack tools which we'll use

ref. slack discussions: #1, #2

/cc @Katharine @spiffxp @ameukam

Signed-off-by: Bart Smykla bsmykla@vmware.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra labels Apr 24, 2020
@bartsmykla bartsmykla force-pushed the slack-infra-tools-container-registry branch from 0fc8bbb to a09d5c2 Compare April 24, 2020 06:10
@bartsmykla bartsmykla mentioned this pull request Apr 24, 2020
Closed
4 tasks
ameukam
ameukam reviewed Apr 24, 2020
View reviewed changes
groups/groups.yaml
ACL for staging Slack Tools
settings:
ReconcileMembers: "true"
owners:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also @jeefy ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameukam Could you give me his email please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be added later.

@ameukam
Copy link
Member

ameukam commented Apr 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2020
@bartsmykla bartsmykla force-pushed the slack-infra-tools-container-registry branch from a09d5c2 to ed8f2cd Compare April 30, 2020 10:11
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2020
@bartsmykla bartsmykla changed the title Prepared slack-tools registry namespace Prepared slack-infra registry namespace Apr 30, 2020
@bartsmykla bartsmykla force-pushed the slack-infra-tools-container-registry branch from ed8f2cd to c59c7a4 Compare April 30, 2020 10:12
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 30, 2020
Prepared slack-tools registry namespace
614ded7 
Signed-off-by: Bart Smykla <bsmykla@vmware.com>
@bartsmykla bartsmykla force-pushed the slack-infra-tools-container-registry branch from c59c7a4 to 614ded7 Compare April 30, 2020 10:13
@bartsmykla
Copy link
Contributor Author

As we discussed at yesterday's community call I changed the names from slack-tools to slack-infra.

@ameukam
Copy link
Member

ameukam commented Apr 30, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 30, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bartsmykla, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3a467c2 into kubernetes:master Apr 30, 2020
@bartsmykla bartsmykla deleted the slack-infra-tools-container-registry branch April 30, 2020 15:47
@spiffxp
Copy link
Member

spiffxp commented Apr 30, 2020

ran make -C groups -- --confirm

@spiffxp
Copy link
Member

spiffxp commented Apr 30, 2020

ran ensure-staging-storage.sh slack-infra

@spiffxp spiffxp mentioned this pull request May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@Katharine Katharine Awaiting requested review from Katharine

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bartsmykla @ameukam @spiffxp @k8s-ci-robot