Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote CoreDNS v1.7.0 #976

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Conversation

rajansandeep
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2020
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 22, 2020
@johnbelamaric
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 76b402b into kubernetes:master Jun 22, 2020
@stp-ip
Copy link
Member

stp-ip commented Jun 23, 2020

Note: Vanity Domain Flip hasn't happened yet (tracked in kubernetes/release#270) and therefore without the legacy way this won't show up on k8s.gcr.io for a few more weeks most likely. The staging image should work so.

@rajansandeep
Copy link
Contributor Author

@stp-ip @johnbelamaric In that case, can CoreDNS 1.7.0 be promoted to k8s.gcr.io manually?
We plan to include it for k8s 1.19

@stp-ip
Copy link
Member

stp-ip commented Jun 24, 2020

@thockin can you push v1.7.0 the legacy way. Already in the staging repo.
Reference to the last "manual" push: kubernetes/kubernetes#88343

@stp-ip
Copy link
Member

stp-ip commented Jun 24, 2020

/assign @thockin

@thockin
Copy link
Member

thockin commented Jun 26, 2020

I don't see this tag in the new repo either - does it actually exist?

@thockin
Copy link
Member

thockin commented Jun 26, 2020

e.g. gcr.io/k8s-staging-coredns/coredns:v1.7.0 and us.gcr.io/k8s-artifacts-prod/coredns/coredns:v1.7.0 should exist.

@listx

@listx
Copy link
Contributor

listx commented Jun 29, 2020

I see in the logs for the promoter that the image (exact sha 73ca82b4ce829766d4f1f10947c3a338888f876fbed0540dc849c89ff256e90c asked-for in the manifest) was not found in the staging repo:

E0629 15:33:03.177923      12 inventory.go:482] edge {{gcr.io/k8s-staging-coredns   true} {coredns v1.7.0} sha256:73ca82b4ce829766d4f1f10947c3a338888f876fbed0540dc849c89ff256e90c {asia.gcr.io/k8s-artifacts-prod/coredns k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com  false} {coredns v1.7.0}}: skipping gcr.io/k8s-staging-coredns/  coredns@sha256:73ca82b4ce829766d4f1f10947c3a338888f876fbed0540dc849c89ff256e90c because it is _LOST_ (can't find it in src registry!)

@thockin
Copy link
Member

thockin commented Jun 29, 2020 via email

@rajansandeep
Copy link
Contributor Author

The image is now available, http://gcr.io/k8s-staging-coredns/coredns:1.7.0
thank you @stp-ip for pushing it.

@stp-ip
Copy link
Member

stp-ip commented Jun 30, 2020

sidenote: on the tag
"1.7.0" is used in staging and the legacy process
"v1.7.0" is used with the promoted images to make them more consistent with the other promoted images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants