Merge pull request #9112 from Hellcatlk/UnitTestCase

Add unit test case for pkg/k8sversion/version_test.go
kubernetes · May 22, 2020 · 212ac0a · 212ac0a
2 parents 553a081 + 41a216a
commit 212ac0a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/k8sversion/version_test.go b/pkg/k8sversion/version_test.go
@@ -25,6 +25,8 @@ func TestParse(t *testing.T) {
 		Input    string
 		Expected string
 	}{
+		{Input: "", Expected: "unable to parse kubernetes version \"\""},
+		{Input: "abc", Expected: "unable to parse kubernetes version \"abc\""},
 		{Input: "1.1.0", Expected: "1.1.0"},
 		{Input: "1.2.0", Expected: "1.2.0"},
 		{Input: "1.3.0", Expected: "1.3.0"},
@@ -48,7 +50,9 @@ func TestParse(t *testing.T) {
 	for _, g := range grid {
 		actual, err := Parse(g.Input)
 		if err != nil {
-			t.Errorf("error parsing %q: %v", g.Input, err)
+			if err.Error() != g.Expected {
+				t.Errorf("error parsing %q: %v", g.Input, err)
+			}
 			continue
 		}
 		if actual.String() != g.Expected {