Skip to content

Commit

Permalink
use dl.k8s.io not gs://kubernetes-release
Browse files Browse the repository at this point in the history
  • Loading branch information
KlwntSingh committed May 11, 2023
1 parent 4d974d4 commit d6776bb
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion nodeup/pkg/model/kubelet.go
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ func (b *KubeletBuilder) addContainerizedMounter(c *fi.NodeupModelBuilderContext
// TODO: leverage assets for this tar file (but we want to avoid expansion of the archive)
c.AddTask(&nodetasks.Archive{
Name: "containerized_mounter",
Source: "https://storage.googleapis.com/kubernetes-release/gci-mounter/mounter.tar",
Source: "https://dl.k8s.io/gci-mounter/mounter.tar",

This comment has been minimized.

Copy link
@aojea

aojea Jul 30, 2023

Member

This comment has been minimized.

Copy link
@hakman

hakman Jul 31, 2023

Member

Thanks for the ping @aojea. I asked @ameukam to take a look.

This comment has been minimized.

Copy link
@aojea

aojea Jul 31, 2023

Member

if is working is ok otherwise just rever the usl for this specific file to https://storage.googleapis.com/kubernetes-release, like in the linked PR

Hash: "6a9f5f52e0b066183e6b90a3820b8c2c660d30f6ac7aeafb5064355bf0a5b6dd",
TargetDir: path.Join(containerizedMounterHome, "rootfs"),
})
Expand Down
2 changes: 1 addition & 1 deletion nodeup/pkg/model/tests/golden/side-loading/cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
iam: {}
kubelet:
anonymousAuth: false
kubernetesVersion: https://storage.googleapis.com/kubernetes-release/release/v1.22.0
kubernetesVersion: https://dl.k8s.io/release/v1.22.0
masterPublicName: api.minimal.example.com
networkCIDR: 172.20.0.0/16
networking:
Expand Down
2 changes: 1 addition & 1 deletion upup/pkg/fi/cloudup/apply_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,7 @@ func (c *ApplyClusterCmd) addFileAssets(assetBuilder *assets.AssetBuilder) error
if components.IsBaseURL(c.Cluster.Spec.KubernetesVersion) {
baseURL = c.Cluster.Spec.KubernetesVersion
} else {
baseURL = "https://storage.googleapis.com/kubernetes-release/release/v" + c.Cluster.Spec.KubernetesVersion
baseURL = "https://dl.k8s.io/release/v" + c.Cluster.Spec.KubernetesVersion
}

c.Assets = make(map[architectures.Architecture][]*mirrors.MirroredAsset)
Expand Down
4 changes: 2 additions & 2 deletions upup/pkg/fi/cloudup/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ func ensureKubernetesVersion(c *kops.Cluster) error {
}

// FindLatestKubernetesVersion returns the latest kubernetes version,
// as stored at https://storage.googleapis.com/kubernetes-release/release/stable.txt
// as stored at https://dl.k8s.io/release/stable.txt
// This shouldn't be used any more; we prefer reading the stable channel
func FindLatestKubernetesVersion() (string, error) {
stableURL := "https://storage.googleapis.com/kubernetes-release/release/stable.txt"
stableURL := "https://dl.k8s.io/release/stable.txt"
klog.Warningf("Loading latest kubernetes version from %q", stableURL)
b, err := vfs.Context.ReadFile(stableURL)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion upup/pkg/fi/cloudup/networking_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
)

func Test_FindCNIAssetFromEnvironmentVariable(t *testing.T) {
desiredCNIVersion := "https://storage.googleapis.com/kubernetes-release/network-plugins/cni-TEST-VERSION.tar.gz"
desiredCNIVersion := "https://dl.k8s.io/network-plugins/cni-TEST-VERSION.tar.gz"
desiredCNIVersionHash := "sha256:0000000000000000000000000000000000000000000000000000000000000000"

t.Setenv(ENV_VAR_CNI_ASSET_URL, desiredCNIVersion)
Expand Down

0 comments on commit d6776bb

Please sign in to comment.