Implementing kubelet GC settings in kops

[markine]

I'm looking to experiment with garbage collection on a cluster created by kops. I need to specify custom flags for kubelet (/etc/sysconfig/kubelet). Two issues:

How do I edit the Kubelet part of the cluster spec? I tried manually downloading cluster.spec from S3, editing it, and uploading it back. 'kube update' did not recognize any changes made to the kubelet stanza.

What needs to happen for kops to process the GC flags? The GC config flags are here: http://kubernetes.io/docs/admin/garbage-collection/. These settings are commented out of the kubelet spec in kops:

ImageGCHighThresholdPercent :

kops/pkg/apis/kops/componentconfig.go

Line 152 in 9e79aca

//ImageGCHighThresholdPercent int32 `json:"imageGCHighThresholdPercent"`

ImageGCLowThresholdPercent:

kops/pkg/apis/kops/componentconfig.go

Line 156 in 9e79aca

//ImageGCLowThresholdPercent int32 `json:"imageGCLowThresholdPercent"`

Thank you.

[chrislovecnm]

Take a look at #1083

Also take a look at

[chrislovecnm]

The API docs under developer, also I cannot find the issue for the process that we are working on how to contribute

[chrislovecnm]

Docs on API https://github.com/kubernetes/kops/blob/master/docs/development/api_updates.md

[chrislovecnm]

#1194 <- start on a howto contribute.

Also we have dev office hours tomorrow, see the readme

[markine]

@chrislovecnm Thank you for a fast reply and the info!

Could you please answer the question re: expected method of modifying the full cluster.spec? I could not get 'kops update cluster' to pick up changes to existing fields in the spec, albeit I only tried one or two fields.

[chrislovecnm]

@markine you are trying to update the api, need api values, and need to regenerate the api. Feel free to push a PR and we can comment on the code!