Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis is not building channels folder #2070

Closed
chrislovecnm opened this issue Mar 9, 2017 · 4 comments
Closed

Travis is not building channels folder #2070

chrislovecnm opened this issue Mar 9, 2017 · 4 comments

Comments

@chrislovecnm
Copy link
Contributor

So we have code in the channels folder that does not have unit tests, and is not being built by travis. e2e caught it, but maybe we should do more of the builds with travis as well. I do not think we are actually building kops ...

  • channels
  • protokube
  • dnscontroller

All not built with travis.
@justinsb
Copy link
Member

We run the protokube & dns-controller tests as part of the test target.

@chrislovecnm
Copy link
Contributor Author

channels tests are not being run ...

@chrislovecnm
Copy link
Contributor Author

I seem to be wrong ... but oddness that this was found: #2953

@justinsb
Copy link
Member

Fixed in #2958

justinsb added a commit to justinsb/kops that referenced this issue Jul 15, 2017
@justinsb
Add back integration tests into CI
9e8312a 
Looks like I accidentally (rebase?) removed it in
a7c2c55

Fix kubernetes#2070
aknuds1 pushed a commit to aknuds1/kops that referenced this issue Aug 25, 2017
@justinsb @aknuds1
Add back integration tests into CI
8278d26 
Looks like I accidentally (rebase?) removed it in
a7c2c55

Fix kubernetes#2070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinsb @chrislovecnm