Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to specify CoreDNS version in cluster manifest #7776

Closed
ghost opened this issue Oct 11, 2019 · 5 comments · Fixed by #7794
Closed

Feature to specify CoreDNS version in cluster manifest #7776

ghost opened this issue Oct 11, 2019 · 5 comments · Fixed by #7794

Comments

@ghost
Copy link

ghost commented Oct 11, 2019

1. Describe IN DETAIL the feature/behavior/change you would like to see.
With k8s 1.14 there is a bug in which coreDNS can crash. The fix for this is easy - just update the version of coreDNS. It would be nice if kops allowed you to specify a version of coreDNS in the cluster manifest.

2. Feel free to provide a design supporting your feature request.

  kubeDNS:
    provider: CoreDNS
    version: 1.4.0
@gjtempleton
Copy link
Member

gjtempleton commented Oct 15, 2019

I don't think this bug should be happening at master due to the merging of #7492 ?

Have you been able to reproduce the crashing behaviour?

FWIW I think the ability to specify a version of CoreDNS is separately potentially useful, however we'd need to be careful around the default CoreFiles provided for each version.

I think it would probably be most useful in conjunction with #7376 to allow users to override both the CoreDNS version and CoreFile together.

Also porting over from Slack that it was decided against going from 1.3.1 to 1.4.0 in k/k due to CoreDNS not tracking the deprecation policy with their plugins at the time, as well as a known bug in one of the plugins: kubernetes/kubernetes#75414 (comment)

@ghost
Copy link
Author

ghost commented Oct 16, 2019

Haven't experienced the crashing behaviour. But if I did (or do in the future), it would be nice to have a way to change versions of CoreDNS.

@gjtempleton
Copy link
Member

gjtempleton commented Oct 16, 2019 via email

@vdoodala
Copy link

vdoodala commented Oct 17, 2019

i have noticed the coredns pods crashing for sometime and started running again, due to which we have experienced dns issues for couple of minutes. I am running on 1.14.6 k8s version.

coredns-b878d8cb8-c7flq 1/1 Running 4 2d5h
coredns-b878d8cb8-rdhw7 1/1 Running 2 2d5h

github.com/coredns/coredns/plugin/kubernetes/controller.go:322: Failed to list *v1.Namespace: Get https://:443/api/v1/namespaces?limit=500&resourceVersion=0: dial tcp :443: i/o timeout
E1017 01:45:15.905212 1 reflector.go:134] github.com/coredns/coredns/plugin/kubernetes/controller.go:322: Failed to list *v1.Namespace: Get https://:443/api/v1/namespaces?limit=500&resourceVersion=0: dial tcp :443: i/o timeout

Any insights ???

@ghost
Copy link
Author

ghost commented Oct 17, 2019

Phew, glad to hear that! I've raised #7794 which I believe would meet your wants completely for an ability to override the version of CoreDNS used as it's something we may want to use at some point as well. Give it a look over and let me know what you think.

On Wed, Oct 16, 2019 at 10:21 PM Vihan Agarwal @.***> wrote: Haven't experienced the crashing behaviour. But if I did (or do in the future), it would be nice to have a way to change versions of CoreDNS. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7776?email_source=notifications&email_token=ABRHKBQ4VLNVGVOPMNTFCD3QO6ATZA5CNFSM4I74KNT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBN7DYI#issuecomment-542896609>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRHKBSCWVO74TENGGD564DQO6ATZANCNFSM4I74KNTQ .

Looks good. Will this be released in 1.14.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants