Simplify node local dns #10059
Merged
Simplify node local dns #10059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
added 2 commits
October 16, 2020 12:46
Since we use the local IP we don't need the iptables rule for the cluster dns IP
olemarkus
force-pushed
the
nld-no-iptables
branch
from
f8166b2 to
29a1cb2
Compare
|
/test pull-kops-e2e-cni-kuberouter |
olemarkus
force-pushed
the
nld-no-iptables
branch
from
9ee89e8 to
4344cc2
Compare
k8s-ci-robot
added
size/XL
|
/test pull-kops-e2e-cni-calico |
|
/retest |
olemarkus
force-pushed
the
nld-no-iptables
branch
from
4344cc2 to
29a1cb2
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 16, 2020
…059-origin-release-1.18 Automated cherry pick of #10059: Don't let node-local-dns add iptables rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we actually control the kubelet cluster dns IP we don't need to make things complex with iptables rules and complex port bindings.
That upstream defaults to these is only to make things simpler for those deploying this to vendor managed k8s clusters.
I think other maintainers suggested this when reviewing the PR that introduced this addon.