-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eBPF dataplane support for Calico CNI #10069
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
upup/models/cloudup/resources/addons/networking.projectcalico.org/k8s-1.16.yaml.template
Outdated
Show resolved
Hide resolved
@@ -3836,6 +3863,20 @@ spec: | |||
name: kubernetes-services-endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use the kubernetes-services-endpoint
config map that we now have for KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT. All the components are alrady configured to pick that up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this require first to move to the Operator first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure you need to do this conditionally. For cilium I chose to just always do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we merge logic from different manifests, it will be easier later to track why these were added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this require first to move to the Operator first?
No, we have the same config map in both install methods (but for operator it needs to be in the operator's namespace, not kube-system). If you look a few lines above you can see the config map ref in your manifest ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks! :)
eb0e042
to
3e67d28
Compare
ab0bef1
to
7b00239
Compare
@@ -3836,6 +3863,20 @@ spec: | |||
name: kubernetes-services-endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure you need to do this conditionally. For cilium I chose to just always do this.
upup/models/cloudup/resources/addons/networking.projectcalico.org/k8s-1.16.yaml.template
Show resolved
Hide resolved
/lgtm |
https://docs.projectcalico.org/about/about-ebpf
https://docs.projectcalico.org/maintenance/enabling-bpf
https://docs.projectcalico.org/reference/felix/configuration#ebpf-dataplane-configuration