Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kops Go build supported versions 1.15 #10099

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Update Kops Go build supported versions 1.15 #10099

merged 1 commit into from
Oct 25, 2020

Conversation

bmelbourne
Copy link
Contributor

@bmelbourne bmelbourne commented Oct 24, 2020 •
edited
Loading

Update Kops documentation to reflect support for Go versions go1.15+.

Kops make verify and make all examples test successfully tested against Go versions go1.15 and go1.15.3.

Latest Go version go1.13.15 is no longer supported due to the following error...

$ go version
go version go1.13.15 linux/amd64

$ make clean && make apimachinery
if test -e /c/GitHub/kops/.build; then rm -rfv /c/GitHub/kops/.build; fi
bazel clean
INFO: Starting clean (this may take a while). Consider using --async if the clean takes more than several minutes.
rm -rf tests/integration/update_cluster/*/.terraform
sh -c hack/make-apimachinery.sh
-mod=mod not supported (can be '', 'readonly', or 'vendor')
make: *** [Makefile:526: apimachinery-codegen] Error 1

@k8s-ci-robot
Copy link
Contributor

Hi @bmelbourne. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2020
hakman
hakman reviewed Oct 25, 2020
View reviewed changes
docs/development/building.md Outdated
@@ -47,5 +47,5 @@ and then configure your IDE to connect its debugger to port 2345 on localhost.

- Make sure `$GOPATH` is set, and your [workspace](https://golang.org/doc/code.html#Workspaces) is configured.
- kops will not compile with symlinks in `$GOPATH`. See issue go issue [17451](https://github.com/golang/go/issues/17451) for more information
- building kops requires go 1.12 or 1.13
- building kops requires go 1.14 or 1.15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is quite a good change. Always forget to change here. Could we say just that build requires 1.15?
Would avoid confusions when some generate / update / test command fails because of 1.14. We don't test anymore with 1.14 at all.

Suggested change
- building kops requires go 1.14 or 1.15
- building kops requires go 1.15

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Although, I didn't experience any build issues with version go1.14, I'm always happy to go with the latest version!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. There are a few hack/verify-* and hack/update-* commands that don't work with 1.14. Better not confuse people.

@hakman
Copy link
Member

hakman commented Oct 25, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmelbourne, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2020
@hakman hakman changed the title Update Kops Go build supported versions 1.14/1.15 Update Kops Go build supported versions 1.15 Oct 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit e0e41a6 into kubernetes:master Oct 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 25, 2020
@bmelbourne bmelbourne deleted the update-kops-go-build-versions branch October 25, 2020 10:34
@bmelbourne bmelbourne mentioned this pull request Jan 10, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman left review comments

@mikesplain mikesplain Awaiting requested review from mikesplain

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@bmelbourne @k8s-ci-robot @hakman