-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove copyright YEAR from generated Go files #10520
Remove copyright YEAR from generated Go files #10520
Conversation
Hi @bmelbourne. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @KashifSaadat |
@rifelpet |
/ok-to-test |
Thanks for fixing this! I'm glad that python script will be more in line with k/k https://github.com/kubernetes/kubernetes/blob/cea1d4e20b4a7886d8ff65f34c6d4f95efcb4742/hack/boilerplate/boilerplate.py /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmelbourne, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…20-origin-release-1.19 Automated cherry pick of #10520: Remove copyright YEAR from generated Go files
What this PR does / why we need it:
Fixes the following issue in kops CI test
make quick-ci
related to the change to Copyright 2021 in the Go boilerplate headers.Similar issue kubernetes/kubernetes#59172 already addressed in Kubernetes project back in 2018.
Which issue(s) this PR fixes
Fixes #10515
Special notes for your reviewer:
hack/boilerplate/boilerplate.py
has been copied from Kubernetes as this project uses a similar approach to re-generating Go boilerplate headers and has been well tested for several years.https://github.com/kubernetes/kubernetes/blob/master/hack/boilerplate/boilerplate.py