Upgrade Go v1.15.6 / Bazel v3.4.1

[bmelbourne]

What this PR does / why we need it:

• Upgrade Go v1.15.5 -> v1.15.6
• Upgrade Bazel v2.2.0 -> v3.4.1
• Upgrade Bazel Rules v0.24.7 -> v0.25.1
• Upgrade Bazel Gazelle v0.19.1/v0.22.2 -> v0.22.3

Which issue(s) this PR fixes:

Special notes for your reviewer:

[k8s-ci-robot]

Hi @bmelbourne. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

Really nice to see Bazel bumped to latest. Thanks for doing this @bmelbourne.
/ok-to-test

[olemarkus]

/ok-to-test

[bmelbourne]

@hakman @olemarkus
The pull-kops-bazel-build job appears to be using an image gcr.io/k8s-testimages/kubekins-e2e:v20210107-e4af2d6-experimental which doesn't have Bazel v3.7.2 installed.

Do you know how I could build an updated image with the correct version of Bazel installed and then update the CI job?

[hakman]

I think the bazel version should be 3.4.1 for now:
https://github.com/kubernetes/test-infra/blob/master/images/kubekins-e2e/variants.yaml

[bmelbourne]

I think the bazel version should be 3.4.1 for now:
https://github.com/kubernetes/test-infra/blob/master/images/kubekins-e2e/variants.yaml

That would work and would align with Kubernetes.

https://github.com/kubernetes/kubernetes/blob/master/build/root/.bazelversion

It would mean downgrading Go to v1.15.5 though.

[hakman]

Why would Go need downgrading?

[bmelbourne]

Why would Go need downgrading?

Not necessarily I guess, it's only if you wanted to keep it consistent with the kOps workflows.

variants:
  experimental:
    CONFIG: experimental
    GO_VERSION: 1.15.5
    K8S_RELEASE: stable
    BAZEL_VERSION: 3.4.1
    OLD_BAZEL_VERSION: 2.2.0
    UPGRADE_DOCKER: 'true'

I'm happy to stick with Go v1.15.6 otherwise it means creating another branch and PR.

[hakman]

Let's just try Bazel 3.4.1. The go version from the image is not that important in this case. Bazel should pull the one set in the workspace.

[bmelbourne]

/assign @rdrgmnzs

[hakman]

I think we have a winner. Thanks @bmelbourne.
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmelbourne, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olemarkus]

/test pull-kops-e2e-k8s-containerd

[hakman]

/retest