If EBS CSI Driver is installed, create a new default SC #11425
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
olemarkus
force-pushed
the
csi-sc
branch
2 times, most recently
from
76a5fb3 to
d3ab949
Compare
k8s-ci-robot
added
size/L
| provisioner: ebs.csi.aws.com | ||
| allowVolumeExpansion: true | ||
| volumeBindingMode: WaitForFirstConsumer | ||
| {{ end }} |
There was a problem hiding this comment.
won't we need smth like this in here?
parameters:
type: gp3
encrypted: "true"There was a problem hiding this comment.
ah, gp3 its the default option of CSI provisioner i guess ^^
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
/retest |
| @@ -40,6 +42,22 @@ parameters: | |||
| allowVolumeExpansion: true | |||
| volumeBindingMode: WaitForFirstConsumer | |||
|
|
|||
| {{ if WithDefaultBool .CloudConfig.AWSEBSCSIDriver.Enabled false }} | |||
| --- | |||
There was a problem hiding this comment.
Is there a process for disabling the EBS CSI Driver? I suppose all the PVs using this StorageClass would have to be deleted first or they would become inaccessable. So then it would be safe to delete the StorageClass resource?
|
@olemarkus: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-rebase
|
@olemarkus: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close This one was merged as part of #10730 |
|
@olemarkus: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yet another SC. This will make all new PVs use the native SC, which will use better defaults such as gp3 volumes.