Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using IRSA for EBS CSI Driver #11747

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Allow using IRSA for EBS CSI Driver #11747

merged 2 commits into from
Jun 18, 2021

Conversation

olemarkus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2021
@k8s-ci-robot k8s-ci-robot added area/addons size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2021
@olemarkus olemarkus requested a review from rifelpet June 12, 2021 17:01
@olemarkus olemarkus force-pushed the irsa-ebscsidriver branch 3 times, most recently from 530c4d7 to 0bc53a1 Compare June 13, 2021 10:16
@johngmyers
Copy link
Member

Can we not remove permissions from the instance role when both the AWS driver and IRSA are enabled?

I notice a bunch of permissions are using the legacy tags. Are these all for dealing with volumes previously created? I hope we're not relying on having legacy tags on new volumes.

@olemarkus
Copy link
Member Author

We are not relying on the legacy tags beyond these permissions and we can change these policies later when the in-tree plugin is no longer supported.

@olemarkus
Copy link
Member Author

We can also remove permissions from the master role, but I want to see some green e2es before I start removing things. But I do commit to removing as much of the master permissions as we can for the 1.22 release.

@olemarkus olemarkus force-pushed the irsa-ebscsidriver branch from 0bc53a1 to e7dd34a Compare June 16, 2021 19:34
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2021
@olemarkus olemarkus force-pushed the irsa-ebscsidriver branch from e7dd34a to 739a017 Compare June 16, 2021 20:10
@olemarkus
Copy link
Member Author

I remove the relevant permissions now. There are only volume-related permissions remaining that etcd-manager require to attach its own volumes.

@olemarkus
Copy link
Member Author

/retest

@olemarkus
Copy link
Member Author

/cc @johngmyers

@k8s-ci-robot k8s-ci-robot requested a review from johngmyers June 17, 2021 06:06
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2021
@olemarkus olemarkus force-pushed the irsa-ebscsidriver branch from 739a017 to 33a7de6 Compare June 18, 2021 06:06
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2021
@johngmyers
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 94bf1f3 into kubernetes:master Jun 18, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@mikesplain mikesplain Awaiting requested review from mikesplain

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@olemarkus @johngmyers @k8s-ci-robot