Enable cross-subnet mode with Calico by default #11810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/addons
size/S
hakman
force-pushed
the
ipv6_disable_calico_awssrcdstcheck
branch
from
9e587c7 to
3764ab7
Compare
hakman
force-pushed
the
ipv6_disable_calico_awssrcdstcheck
branch
from
3764ab7 to
8f65c09
Compare
k8s-ci-robot
added
size/L
hakman
changed the title
hakman
force-pushed
the
ipv6_disable_calico_awssrcdstcheck
branch
4 times, most recently
from
8e53181 to
2709e6a
Compare
|
I'm not terribly knowledgeable about Calico. @olemarkus do you have expertise in this area? |
|
No, I'm afraid not. Our e2e are not multi-az either. That would have been handy to verify this doesn't cause something unexpected to happen. |
|
We have this HA test for masters. |
|
Seems all good. I can add more periodic tests later for vxlan and maybe bpf. |
johngmyers
requested changes
Jun 21, 2021
hakman
force-pushed
the
ipv6_disable_calico_awssrcdstcheck
branch
3 times, most recently
from
8211ab8 to
8e23f21
Compare
|
/retest |
johngmyers
reviewed
Jun 21, 2021
hakman
force-pushed
the
ipv6_disable_calico_awssrcdstcheck
branch
from
8e23f21 to
8a1cdd7
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest |
johngmyers
reviewed
Jun 22, 2021
hakman
force-pushed
the
ipv6_disable_calico_awssrcdstcheck
branch
from
8a1cdd7 to
e57fd05
Compare
|
/retest |
1 similar comment
|
/retest |
johngmyers
requested changes
Jun 25, 2021
hakman
force-pushed
the
ipv6_disable_calico_awssrcdstcheck
branch
from
e57fd05 to
a12b314
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most kOps setup have at least 2 subnets so, the optimal setup is to:
CrossSubnet(other possible options areAlwaysandNone)/cc @johngmyers @olemarkus