-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support large/slow downloads #11884
support large/slow downloads #11884
Conversation
current download code was using http.client timeout, that will interrupt reading of the response body, breaking slow downloads or very large files. This patch modified the http client to detect idle downloads, and fail after 30 seconds of innactivity. It still keeps a global timeout of 5 minutes.
5 minutes is a little much. Usually when nodes are IPv4 only, it takes 1-2 seconds to download such files. Let's see how this goes. |
I made it configurable, just choose a random value, the point is that now we can differentiate between idle and slow connections |
Cool. Thanks. 😄 |
Mostly ok, doing a few more runs. |
/test pull-kops-e2e-ipv6-conformance |
1 similar comment
/test pull-kops-e2e-ipv6-conformance |
Just perfect, thanks @aojea! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
current download code was using http.client timeout, that will
interrupt reading of the response body, breaking slow downloads
or very large files.
This patch modified the http client to detect idle downloads, and
fail after 30 seconds of innactivity. It still keeps a global
timeout of 5 minutes.