Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #12141: Bump cilium to 1.10.3 #12142

Conversation

olemarkus
Copy link
Member

Cherry pick of #12141 on release-1.21.

#12141: Bump cilium to 1.10.3

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2021
@johngmyers
Copy link
Member

This is bumping to 1.9.9, not 1.10.3. The PR title and commit messages should be adjusted appropriately.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2021
@hakman
Copy link
Member

hakman commented Aug 13, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2021
@hakman
Copy link
Member

hakman commented Aug 13, 2021

This is bumping to 1.9.9, not 1.10.3. The PR title and commit messages should be adjusted appropriately.

I think it's a little late as it's a cherry-pick, right?

@olemarkus
Copy link
Member Author

The title of this PR was correct for master. It technically is the same change just different defaults. Changing the title now won't help as I think the release log will still resolve to the original PR.

@olemarkus
Copy link
Member Author

I'll adjust the original PR title

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2021
@hakman
Copy link
Member

hakman commented Aug 13, 2021

@olemarkus Maybe in this case not make it a cherry-pick?

@olemarkus
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2021
@olemarkus
Copy link
Member Author

Thanks for catching this one. Replaced with #12146

/close

@k8s-ci-robot
Copy link
Contributor

@olemarkus: Closed this PR.

In response to this:

Thanks for catching this one. Replaced with #12146

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants