Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DigitalOcean] Code refactor to use the existing dnsprovider package #12173

Merged
merged 3 commits into from
Aug 19, 2021
Merged

[DigitalOcean] Code refactor to use the existing dnsprovider package #12173

merged 3 commits into from
Aug 19, 2021

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented Aug 18, 2021

  • Move files from pkg/resources/digitalocean/dns to dnsprovider/pkg/dnsprovider/providers/do so it's consistent with other cloud providers.
  • Was seeing issues where protokube was not able to fetch dnsprovider for DO. (it continued to work for gossip cluster, but had issues only for dnsProviderID with DO) Tested with this change and it's working as expected.
  • It looks like it was caused due to my previous change - [Digital Ocean] Code cleanup with no functional modifications #11592

FYI @timoreimann

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/digitalocean Issues or PRs related to digitalocean provider label Aug 18, 2021
@srikiz
Copy link
Contributor Author

srikiz commented Aug 18, 2021

/retest

hakman
hakman approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srikiz :).

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit ecb85a2 into kubernetes:master Aug 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 19, 2021
@srikiz srikiz deleted the DO-Fix-DNSProvider-Interface-Package branch August 20, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@mikesplain mikesplain Awaiting requested review from mikesplain

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/digitalocean Issues or PRs related to digitalocean provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@srikiz @k8s-ci-robot @hakman