Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[addons/node-local-dns] Bump version and make image field configurable #12219

Merged
merged 1 commit into from
Sep 1, 2021
Merged

[addons/node-local-dns] Bump version and make image field configurable #12219

merged 1 commit into from
Sep 1, 2021

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Aug 29, 2021 •
edited
Loading

As per kubernetes/dns@3b17e06, node-local-dns addon is now built with the latest coreDNS base (v1.8) and that brings great consistency between cache and upstream servers in a manner of configuration syntax, metrics name convention, etc.

So in this commit, we bump node-local-dns image to latest v1.20.0 which is build upon latest coreDNS and also add support for overriding this field.

Signed-off-by: dntosas ntosas@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2021
@dntosas dntosas force-pushed the nodelocaldns-bump-version branch from a55989c to b9999d1 Compare August 29, 2021 10:34
@dntosas dntosas force-pushed the nodelocaldns-bump-version branch 2 times, most recently from 31f49ae to b641a8c Compare August 29, 2021 10:59
@dntosas dntosas changed the title [addons/nodelocaldns] Bump image to latest stable v1.20.0 [addons/node-local-dns] Bump version and make image field configurable Aug 29, 2021
@dntosas dntosas force-pushed the nodelocaldns-bump-version branch from b641a8c to ee49483 Compare August 29, 2021 11:33
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2021
@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2021
@johngmyers
Copy link
Member

Clusters that cannot fetch from public image registries should use the assets.containerRegistry or assets.containerProxy field of the cluster spec. See https://kops.sigs.k8s.io/operations/asset-repository/

olemarkus
olemarkus requested changes Aug 31, 2021
View reviewed changes
docs/addons.md Outdated
@@ -139,6 +141,7 @@ spec:
enabled: true
memoryRequest: 5Mi
cpuRequest: 25m
image: "k8s.gcr.io/dns/k8s-dns-node-cache:1.20.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we support setting image, we shouldn't encourage people to do so in the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true that ^ changing

@dntosas
[addons/nodelocaldns] Bump image to latest stable v1.20.0
f558f24 
 As per
 kubernetes/dns@3b17e06,
 node-local-dns addon is now builded with latest coreDNS base v1.8 and
 that brings great consistency between cache and upstream servers in a
 manner of configuration, metrics name convention, etc.

 So in this commit, we bump node-local-dns image to latest v1.20.0 which
 is build upon latest coreDNS and also add support for overriding this
 field.

Signed-off-by: dntosas <ntosas@gmail.com>
@dntosas dntosas force-pushed the nodelocaldns-bump-version branch from ee49483 to f558f24 Compare August 31, 2021 11:07
@dntosas
Copy link
Contributor Author

dntosas commented Aug 31, 2021

/retest

@dntosas dntosas requested a review from olemarkus August 31, 2021 13:56
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit c70ced2 into kubernetes:master Sep 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Sep 1, 2021
@dntosas dntosas deleted the nodelocaldns-bump-version branch September 1, 2021 20:53
@dntosas dntosas mentioned this pull request Sep 1, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 2, 2021
@k8s-ci-robot
Merge pull request #12247 from dntosas/automated-cherry-pick-of-#1221…
842d09a 
…9-upstream-release-1.22

Automated cherry pick of #12219: Bump image to latest stable v1.20.0
@johngmyers johngmyers modified the milestones: v1.22, v1.23 Oct 8, 2021
@dntosas dntosas mentioned this pull request Oct 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
5 participants
@dntosas @k8s-ci-robot @mikesplain @johngmyers @olemarkus