-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove unneeded network related sysctls" #12415
Conversation
This reverts commit ce08ec6.
/test pull-kops-e2e-cni-weave |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Any idea why those things broke? Canal is unmaintained at the moment. |
…415-origin-release-1.22 Automated cherry pick of #12415: Revert "Remove unneeded network related sysctls"
Most likely the other CNIs set forwarding if not already set. Both Cilium and Calico at least depend on forwarding happening on kernel level when not running in BPF mode. Weave documentation explicitly says it expects forwarding to be enabled outside of the CNI. |
In this case you could have just added IPv4 forwarding instead of reverting the whole thing and adding back the |
This reverts commit ce08ec6.
Removing these sysctls broke a number of CNIs (weave, aws vpc, and canal), and possibly breaks configurations we do not test as well.
The accept_ra sysctls can be removed in a followup.