Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set etcd-manager backup interval #13975

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Add option to set etcd-manager backup interval #13975

merged 1 commit into from
Jul 15, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 14, 2022

Fixes: #13972

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2022
@hakman hakman force-pushed the etcd-manager_backup_interval branch from b9aabb6 to 19ca086 Compare July 14, 2022 06:58
@hakman
Copy link
Member Author

hakman commented Jul 15, 2022

/cc @justinsb

@k8s-ci-robot k8s-ci-robot requested a review from justinsb July 15, 2022 14:58
@justinsb
Copy link
Member

Nice fix!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2022
@hakman hakman mentioned this pull request Jul 15, 2022
Merged
@k8s-ci-robot k8s-ci-robot merged commit b7d4499 into kubernetes:master Jul 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 15, 2022
@dpc
Copy link

dpc commented Jul 15, 2022

Wow. I thought it's such a long shot, and it's landed already. Thanks a lot! ❤️

@hakman hakman deleted the etcd-manager_backup_interval branch July 15, 2022 17:01
@hakman
Copy link
Member Author

hakman commented Jul 15, 2022

My pleasure. If #13983 is merged, you should see it in the next kOps 1.24 release.

k8s-ci-robot added a commit that referenced this pull request Jul 16, 2022
@k8s-ci-robot
Merge pull request #13983 from hakman/automated-cherry-pick-of-#13975…
4963ddc 
…-upstream-release-1.24

Automated cherry pick of #13975: Add option to set etcd-manager backup interval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain Awaiting requested review from mikesplain

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

Optimize cluster backup storage costs
4 participants
@hakman @justinsb @k8s-ci-robot @dpc