Add option to set number of replicas for pod-identity-webhook #13986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/cc @olemarkus |
hakman
force-pushed
the
pod-identity-webhook_replicas
branch
from
f8c1175 to
a76fef1
Compare
justinsb
reviewed
Jul 16, 2022
| @@ -223,7 +223,8 @@ type ClusterSpec struct { | |||
|
|
|||
| // PodIdentityWebhookConfig configures an EKS Pod Identity Webhook. | |||
| type PodIdentityWebhookConfig struct { | |||
| Enabled bool `json:"enabled,omitempty"` | |||
| Enabled bool `json:"enabled,omitempty"` | |||
| Replicas int `json:"replicas,omitempty"` | |||
There was a problem hiding this comment.
I was wondering if it would make sense to set replicas to 0, but I guess someone that wanted to do that would set enabled = false instead.
|
Thanks @hakman /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 19, 2022
…-upstream-release-1.24 Automated cherry pick of #13986: Add option to set number of replicas for pod-identity-webhook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #13931