Check keyset existence before attempting to distrust

[yurrriq]

Fixes #14040

λ kops distrust keypair this-is-not-a-keypair 12345678910
Using cluster from kubectl context: my-cluster.local

Error: keyset not found

[k8s-ci-robot]

Hi @yurrriq. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yurrriq]

Checking for keypair existence before primariness didn't actually work, but now I've tracked down what seems like the culprit

kops/upup/pkg/fi/clientset_castore.go

Lines 113 to 115 in 8560e47

	if errors.IsNotFound(err) {
	return nil, nil
	}

[yurrriq]

See also:

kops/cmd/kops/promote_keypair.go

Lines 160 to 162 in 8560e47

	} else if keyset == nil {
	return fmt.Errorf("keyset not found")
	}

[hakman]

/ok-to-test

[hakman]

👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment