Automated cherry pick of #14463: Fix Prometheus scraping for pod-identity-webhook #14472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
The Service annotation for the pod-identity-webhook is asking Prometheus to scrape its metrics from `https://` but this results in a HTTP 404 Not Found response. The pod-identity-webhook pods expose their metrics via HTTP on TCP port 9999 (the same port where the healthz checks go). Therefore update the annotations to use `http://:9999` instead.
johngmyers
force-pushed
the
automated-cherry-pick-of-#14463-upstream-release-1.25
branch
from
b0dc0b0 to
6aab32b
Compare
hakman
approved these changes
Oct 29, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
johngmyers
deleted the
automated-cherry-pick-of-#14463-upstream-release-1.25
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #14463 on release-1.25.
#14463: Fix Prometheus scraping for pod-identity-webhook
For details on the cherry pick process, see the cherry pick requests page.