-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cluster-autoscaler to run on spot if nothing else is available #14593
Conversation
This is not a solution for spot-only clusters, so I don't think it safely fixes #14411 |
@olemarkus could you expand on why this isn't a solution for spot-only clusters? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For spot-only, the only really safe place to put CAS would be on the control plane. However, using NTH in addition would probably mitigate this to the extent it is a very unlikely scenario.
If you have many IGs with very narrow mix of insistence types, you can still run into this though, but CAS trying to scale up an IG that has no spot capacity, and then get evicted before it has the chance to jump to the next one.
But yeah, this all may be theoretical since we also run two CAS instances, and the likelyhood of both getting reaped is in itself fairly low.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cluster Autoscaler is |
An alternative to #14591
Fixes #14411