Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaleway integration #14629

Closed
wants to merge 8 commits into from
Closed

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Nov 22, 2022

This is the latest version of my work for the integration of Scaleway in kOps.
Commits are squashed in this version for better readability but the original history is still available in the branch scw_init that I left as it were before the big rebase I did after the merge of #14431 in upstream.

EDIT: I meant to open this PR on my own fork and not here as it's way too big, I'll keep making smaller PRs instead. Next up will be the nodeidentity part and the listing of resources for deletion, and then the DNS after that.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2022
@k8s-ci-robot k8s-ci-robot requested a review from hakman November 22, 2022 16:44
@k8s-ci-robot k8s-ci-robot added area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/documentation area/kops-controller needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Mia-Cross. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/nodeup area/provider/scaleway Issues or PRs related to Scaleway provider labels Nov 22, 2022
@hakman
Copy link
Member

hakman commented Nov 22, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2022
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from 769aa74 to 8781e05 Compare December 6, 2022 03:46
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 6, 2022
@k8s-ci-robot
Copy link
Contributor

@Mia-Cross: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-verify-boilerplate 769aa74 link true /test pull-kops-verify-boilerplate
pull-kops-verify-gofmt 769aa74 link true /test pull-kops-verify-gofmt
pull-kops-verify-gomod 769aa74 link true /test pull-kops-verify-gomod
pull-kops-build 769aa74 link true /test pull-kops-build
pull-kops-verify-govet 769aa74 link true /test pull-kops-verify-govet
pull-kops-verify-golangci-lint 769aa74 link true /test pull-kops-verify-golangci-lint
pull-kops-test 769aa74 link true /test pull-kops-test
pull-kops-e2e-k8s-gce-cilium 769aa74 link true /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-k8s-aws-calico 769aa74 link true /test pull-kops-e2e-k8s-aws-calico
pull-kops-e2e-cni-cilium-eni 8781e05 link true /test pull-kops-e2e-cni-cilium-eni
pull-kops-e2e-cni-cilium-etcd 8781e05 link true /test pull-kops-e2e-cni-cilium-etcd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from 8781e05 to 2317313 Compare December 13, 2022 14:14
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 13, 2022
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from 2317313 to 7d3807d Compare December 20, 2022 00:17
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2022
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from 0d767a0 to 166a632 Compare December 20, 2022 15:37
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from 166a632 to 2317313 Compare December 30, 2022 14:48
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2022
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from 2317313 to a84c7d0 Compare December 30, 2022 14:53
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2023
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from a84c7d0 to 1b55d4f Compare January 13, 2023 17:47
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2023
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from 418c638 to 3dbf6fe Compare January 18, 2023 13:53
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from 3dbf6fe to 2f06605 Compare January 25, 2023 15:50
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2023
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch 3 times, most recently from 43e35f8 to 88da74a Compare January 30, 2023 13:01
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023
@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from 1a3adda to 3e3e21e Compare February 2, 2023 13:01
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Mia-Cross Mia-Cross force-pushed the scaleway_integration branch from d55642f to 255119a Compare February 10, 2023 13:23
@Mia-Cross Mia-Cross closed this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons area/api area/documentation area/kops-controller area/nodeup area/provider/scaleway Issues or PRs related to Scaleway provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants