Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Add ec2:DescribeAvailabilityZones to the AWS CCM permissions list #14650

Merged
merged 1 commit into from
Nov 25, 2022
Merged

aws: Add ec2:DescribeAvailabilityZones to the AWS CCM permissions list #14650

merged 1 commit into from
Nov 25, 2022

Conversation

lobziik
Copy link
Member

@lobziik lobziik commented Nov 24, 2022

To workaround the issue with subnets auto-discovery [1] AWS ccm needs to have permission to retrieve information about availability zones (specifically to detect outpost, wavelength, and local zones [2]).

[1] kubernetes/cloud-provider-aws#442
[2] kubernetes/cloud-provider-aws#499

/cc @olemarkus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2022
@hakman
Copy link
Member

hakman commented Nov 24, 2022

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022
@hakman
Copy link
Member

hakman commented Nov 24, 2022

/retest

k8s-ci-robot added a commit that referenced this pull request Nov 24, 2022
…4650-upstream-release-1.24

Automated cherry pick of #14650: Add `ec2:DescribeAvailabilityZones` to the AWS CCM
@hakman
Copy link
Member

hakman commented Nov 24, 2022

@lobziik Seems some other PR merged just before this and a rebase and update of expected files is required. Sorry for the hassle.

k8s-ci-robot added a commit that referenced this pull request Nov 24, 2022
…4650-upstream-release-1.25

Automated cherry pick of #14650: Add `ec2:DescribeAvailabilityZones` to the AWS CCM
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@hakman
Copy link
Member

hakman commented Nov 24, 2022

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2022
To workaround the issue with subnets auto-discovery [1]
AWS ccm needs to have permission to retrieve information about
availability zones (specifically to detect outpost, wavelength, and local zones [2]).

[1] kubernetes/cloud-provider-aws#442
[2] kubernetes/cloud-provider-aws#499
@lobziik
Copy link
Member Author

lobziik commented Nov 25, 2022

@lobziik Seems some other PR merged just before this and a rebase and update of expected files is required. Sorry for the hassle.

@hakman done

@hakman
Copy link
Member

hakman commented Nov 25, 2022

Thanks @lobziik!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2022
@hakman
Copy link
Member

hakman commented Nov 25, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit f6e5731 into kubernetes:master Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. blocks-next cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants