Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't disable AWS src/dst checks in Calico IPv6 #14672

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Don't disable AWS src/dst checks in Calico IPv6 #14672

merged 1 commit into from
Nov 26, 2022

Conversation

johngmyers
Copy link
Member

/assign @olemarkus

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2022
@k8s-ci-robot k8s-ci-robot added area/api size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2022
@hakman
Copy link
Member

hakman commented Nov 26, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2022
@johngmyers
Copy link
Member Author

Looks like I made it impossible to disable src/dst checks on IPv6 in the template. Should I support that or add validation against it?

@hakman
Copy link
Member

hakman commented Nov 26, 2022

Looks like I made it impossible to disable src/dst checks on IPv6 in the template. Should I support that or add validation against it?

Let's not support it at all for IPv6. Should not be needed.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2022
@hakman
Copy link
Member

hakman commented Nov 26, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2022
@hakman
Copy link
Member

hakman commented Nov 26, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6e9b29a into kubernetes:master Nov 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 26, 2022
@johngmyers johngmyers deleted the v6-calico-srcdest branch November 26, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman left review comments

@mikesplain mikesplain Awaiting requested review from mikesplain

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@olemarkus olemarkus

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
4 participants
@johngmyers @hakman @k8s-ci-robot @olemarkus