Refactor terraformWriter.Literal #14680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
johngmyers
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
johngmyers
force-pushed
the
literal-refactor
branch
from
d125b83 to
8b6f297
Compare
johngmyers
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
rifelpet
reviewed
Nov 28, 2022
| "source": "\"${path.module}/data/google_storage_bucket_object_bar_content\"" | ||
| } | ||
| `, | ||
| expectedACLJSON: ` | ||
| { | ||
| "bucket": "foo", | ||
| "object": "${google_storage_bucket_object.bar.output_name}", | ||
| "provider": "${google.files}", | ||
| "object": "google_storage_bucket_object.bar.output_name", |
There was a problem hiding this comment.
I think this needs to be:
Suggested change
| "object": "google_storage_bucket_object.bar.output_name", | |
| "object": "${google_storage_bucket_object.bar.output_name}", |
but I'm not sure if that's just a side effect of how we're using json for unit tests
There was a problem hiding this comment.
That's just a side effect of how JSON is being used for unit tests. JSON is only being used for unit tests at this point, so the "expected" value is arbitrary.
rifelpet
approved these changes
Nov 28, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably best reviewed commit-by-commit.
Moves logic for Literal into the constructors.
/assign @rifelpet