Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS files #14704

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Update OWNERS files #14704

merged 1 commit into from
Dec 2, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 2, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/openstack Issues or PRs related to openstack provider area/provider/spotinst Issues or PRs related to spotinst provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2022
@hakman
Copy link
Member Author

hakman commented Dec 2, 2022

/hold
/kind office-hours

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/office-hours labels Dec 2, 2022
@zetaab
Copy link
Member

zetaab commented Dec 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@johngmyers
Copy link
Member

None of the owners being removed or moved to emeritus (not counting the top-level owner only being removed from lower level files) has performed more than one review or one approval in the period 2021-09-25..2022-09-25.

All owners being retained have performed at least five reviews and five approvals within that period.

@johngmyers
Copy link
Member

/lgtm

@justinsb
Copy link
Member

justinsb commented Dec 2, 2022

As discussed in office hours, it's good to steer PRs to people that are most active. We thank all the new emeritus folk for their contribution and they're always welcome if/when they have more time :-)

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2e231fc into kubernetes:master Dec 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 2, 2022
@hakman hakman deleted the owners_update branch December 2, 2022 21:37
This was referenced Dec 9, 2022
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 9, 2022
@k8s-ci-robot
Merge pull request #14757 from hakman/automated-cherry-pick-of-#14704…
5e64522 
…-upstream-release-1.25

Automated cherry pick of #14704: Update OWNERS files
k8s-ci-robot added a commit that referenced this pull request Dec 9, 2022
@k8s-ci-robot
Merge pull request #14758 from hakman/automated-cherry-pick-of-#14704…
eb945da 
…-upstream-release-1.24

Automated cherry pick of #14704: Update OWNERS files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@justinsb justinsb Awaiting requested review from justinsb

@olemarkus olemarkus Awaiting requested review from olemarkus

@rifelpet rifelpet Awaiting requested review from rifelpet

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@justinsb justinsb

@johngmyers johngmyers

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
5 participants
@hakman @zetaab @johngmyers @justinsb @k8s-ci-robot