Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1alpha3: move networking fields under networking #14706

Merged
merged 3 commits into from
Dec 6, 2022
Merged

v1alpha3: move networking fields under networking #14706

merged 3 commits into from
Dec 6, 2022

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 2, 2022
@k8s-ci-robot k8s-ci-robot requested review from drekle and zetaab December 2, 2022 07:14
@k8s-ci-robot k8s-ci-robot added area/addons area/api area/documentation area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/hetzner Issues or PRs related to Hetzner provider area/provider/openstack Issues or PRs related to openstack provider area/rolling-update labels Dec 2, 2022
@rifelpet
Copy link
Member

rifelpet commented Dec 2, 2022

Could we merge networkCIDR and additionalNetworkCIDRs into a single networkCIDRs field?

@johngmyers
Copy link
Member Author

/retest

@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2022
@hakman
Copy link
Member

hakman commented Dec 6, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@johngmyers
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit e5a835d into kubernetes:master Dec 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 6, 2022
@johngmyers johngmyers deleted the v1alpha3-networking branch December 6, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drekle drekle Awaiting requested review from drekle

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/documentation area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/hetzner Issues or PRs related to Hetzner provider area/provider/openstack Issues or PRs related to openstack provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
5 participants
@johngmyers @rifelpet @olemarkus @hakman @k8s-ci-robot