aws: Skip Route53 cleanup for clusters without DNS

[hakman]

Small cleanup improvement to get tests passing again in kubernetes/cloud-provider-aws#532:

Ginkgo ran 1 suite in 2m57.709627616s
Test Suite Passed
/home/prow/go/src/k8s.io/cloud-provider-aws
I1202 08:29:47.704238   27602 delete_cluster.go:128] Looking for cloud resources to delete
Error: error querying for route53 zones: AccessDenied:
	User: arn:aws:iam::607362164682:user/awstester is not authorized to perform: route53:ListHostedZones
	because no identity-based policy allows the route53:ListHostedZones action
		status code: 403, request id: 911b0c35-ba05-4950-880f-3d78acabfddb
make: *** [Makefile:133: test-e2e] Error 1

/cc @olemarkus @johngmyers @rifelpet

[hakman]

/test pull-kops-e2e-aws-dns-none

[hakman]

/test pull-kops-e2e-kubernetes-do-gossip

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [olemarkus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[johngmyers]

I don't think route53:ListHostedZones is too much to ask for.

I don't like passing in the Cluster. It might not exist anymore: one of our testing AWS accounts had all of its S3 buckets deleted.

I was thinking of using ListResourcesAWS() for a utility to clean up EKS clusters.

[hakman]

I don't think route53:ListHostedZones is too much to ask for.

It is not in general, but for getting started or restricted accounts it may be a problem. Gossip and None DNS don't require it, so most optimal is not to get there.

I don't like passing in the Cluster.

Would passing only the value of cluster.UsesNoneDNS() make it better?

[johngmyers]

Would passing only the value of cluster.UsesNoneDNS() make it better?

Perhaps an exclusion list of (a subset of) AWS services?