Refactor writing of Terraform data sources #14713
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
| if s, ok := item.(string); ok { | ||
| return terraformWriter.LiteralFromStringValue(s), nil | ||
| } | ||
| if s, ok := item.(*string); ok { |
There was a problem hiding this comment.
Nit: Could probably swap the string and *string checks and just fall-through (as we do with reflect.Pointer below)
There was a problem hiding this comment.
I was trying to avoid calling reflect on strings. But that's an unnecessary micro-optimization.
| for _, field := range reflect.VisibleFields(v.Type()) { | ||
| key := field.Tag.Get("cty") | ||
| if key == "" { | ||
| var b strings.Builder |
There was a problem hiding this comment.
Maybe refactor this into its own method, defaultCtyName or similar, just because it would make this method much easier to read?
|
LGTM. I see the tests are passing. Do we have test coverage on the formatting, or are we testing only after passing through a |
johngmyers
force-pushed
the
tf-refactor
branch
from
8f91570 to
b9b433a
Compare
johngmyers
force-pushed
the
tf-refactor
branch
from
b9b433a to
6c1684d
Compare
|
The integration tests give us coverage. This particular change is covered by |
|
/retest |
1 similar comment
|
/retest |
|
Thanks @johngmyers - looks great /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
No description provided.