-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trying to fix the broken list items for ECR permissions #14748
Conversation
Hi @NorseGaud. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hakman , any recommendations on seeing if this fixed the issue? Is there a way to preview the docs? |
@NorseGaud look at the "Details" link of the "deploy/netlify" GitHub check. |
It's now a bulleted list, but the URLs are not links. |
Thanks! /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PLEASE NOTE Before you approve, can someone show me how to see if this works before it's merged in? In my md preview, it looks fine, but it also looked fine before.