Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't drain on rebalance recommendations in SQS mode unless configured #14771

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Don't drain on rebalance recommendations in SQS mode unless configured #14771

merged 2 commits into from
Dec 17, 2022

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2022
@k8s-ci-robot k8s-ci-robot requested a review from zetaab December 12, 2022 01:02
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Dec 12, 2022
@johngmyers johngmyers mentioned this pull request Dec 12, 2022
Closed
@olemarkus
Copy link
Member

Just to ensure I understand the motivation for this PR ...
This only uses the NTH configuration to add/remove specific rules, right? You don't change the templates or NTH behaviour so you don't disable draining as such, only that NTH doesn't have to consume rebalance recommendations it isn't using. The title of the PR suggests to me that it configures NTH behaviour.

@johngmyers
Copy link
Member Author

This PR causes draining to be disabled by not sending NTH the events. If NTH gets a rebalance event, it drains the node.

@johngmyers johngmyers mentioned this pull request Dec 17, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0f5fc06 into kubernetes:master Dec 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 17, 2022
@johngmyers johngmyers deleted the sqs-rebalance branch December 17, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@johngmyers @olemarkus @k8s-ci-robot