Introduce context.Context into some of our "Context" objects #14778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule of thumb is that we shouldn't be embedding a context.Context, but it is reasonable when the lifetime is similar and when the refactor would otherwise be unacceptably large. This is a minimal way to introduce it, based on adding the support needed in the GCS support for serviceAccountIssuerDiscovery. We will need to plumb through the context in many more places over time.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/nodeup
area/provider/aws
olemarkus
approved these changes
Dec 13, 2022
| @@ -38,6 +39,8 @@ var testRunTasksOptions = fi.RunTasksOptions{ | |||
| } | |||
|
|
|||
| func TestElasticIPCreate(t *testing.T) { | |||
| ctx := context.TODO() | |||
There was a problem hiding this comment.
Where we actually have no way of using an existing context that could be propagated, I think we should use context.Background(). And keep using TODO() where we really should attempt to propagate an existing one.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule of thumb is that we shouldn't be embedding a context.Context,
but it is reasonable when the lifetime is similar and when the
refactor would otherwise be unacceptably large.
This is a minimal way to introduce it, based on adding the support
needed in the GCS support for serviceAccountIssuerDiscovery. We will
need to plumb through the context in many more places over time.