Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context threading: finish up ClientSet methods #14807

Closed
wants to merge 3 commits into from
Closed

Context threading: finish up ClientSet methods #14807

wants to merge 3 commits into from

Conversation

justinsb
Copy link
Member

Builds on #14797

More context: all ClientSet methods now accept a Context

The next change in the series!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb by writing /assign @justinsb in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb justinsb mentioned this pull request Dec 18, 2022
Closed
@justinsb justinsb changed the title Context threading #2 Context threading: finish up ClientSet methods Dec 18, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2022
@justinsb
Context threading: more wiring
b59a5b0 
We're aiming to use this for testing immediately and better
logging/tracing in future, but to make the changes manageable breaking
them into a smaller series that don't directly achieve much.
@justinsb
Wire up context from cobra in cmd/kops
ef9635b 
Removes a lot of context.TODO() calls.
@justinsb
More context: all ClientSet methods now accept a Context
81e1e61 
The next change in the series!
@justinsb justinsb force-pushed the pure_context_work_2 branch from bbff5b8 to 81e1e61 Compare December 19, 2022 15:07
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 19, 2022
@k8s-ci-robot
Copy link
Contributor

@justinsb: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justinsb
Copy link
Member Author

justinsb commented Jan 1, 2023

As agreed, we're going to avoid contexts on "builder" methods

/close

@k8s-ci-robot
Copy link
Contributor

@justinsb: Closed this PR.

In response to this:

As agreed, we're going to avoid contexts on "builder" methods

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees
No one assigned
Labels
area/api area/nodeup area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinsb @k8s-ci-robot