Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate control-plane IG size #14848

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Validate control-plane IG size #14848

merged 1 commit into from
Dec 22, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 22, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/api size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 22, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 22, 2022
@hakman
Copy link
Member Author

hakman commented Dec 22, 2022

@olemarkus any objection to cherry-pick this?

@hakman hakman force-pushed the control-plane_ig_max-size branch from 0d41b73 to bead06a Compare December 22, 2022 13:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 22, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Dec 22, 2022
Merged
Closed
@k8s-ci-robot k8s-ci-robot merged commit 6e36b78 into kubernetes:master Dec 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 22, 2022
@hakman hakman deleted the control-plane_ig_max-size branch December 22, 2022 14:23
k8s-ci-robot added a commit that referenced this pull request Dec 22, 2022
@k8s-ci-robot
Merge pull request #14849 from hakman/automated-cherry-pick-of-#14848…
831b1df 
…-upstream-release-1.25

Automated cherry pick of #14848: Validate control-plane IG size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @olemarkus