Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-router to 1.6 #16110

Merged
merged 3 commits into from
Nov 19, 2023
Merged

Conversation

aauren
Copy link
Contributor

@aauren aauren commented Nov 19, 2023

This PR, updates kube-router to the latest stable 1.X release (1.6.0). It is primarily a dependency update release and has been released for several months. If this goes well, the next step would be to upgrade to kube-router 2.X which is the most recent stable release, but comes with a few breaking changes.

I have also removed the deprecation notices for kube-router since I'm now committing to maintaining it. I have split out a 3rd commit that removes the deprecation notices for kube-router from the kops release notes. However, I left it as a separate commit, because I'm not sure if the project considers release notes like that immutable. Let me know the best way to proceed, and I can modify the PR accordingly.

After upgrading it, I have tested it against my own kops cluster and I have also run the kubetest2 e2e tests. kube-router's test results against the sig-network conformance tests are the same both before and after the upgrade. It currently fails 9 of the sig-network conformance tests. This is something that I was already interested in fixing upstream, so I'll work on that on the 2.X release line over the course of the next several months.

FYI @hakman

Copy link

linux-foundation-easycla bot commented Nov 19, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 19, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @aauren!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @aauren. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 19, 2023
@aauren aauren changed the title Update kuberouter 1.6 Update kube-router to 1.6 Nov 19, 2023
@k8s-ci-robot k8s-ci-robot added area/addons area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 19, 2023
@hakman
Copy link
Member

hakman commented Nov 19, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2023
@hakman
Copy link
Member

hakman commented Nov 19, 2023

Thanks @aauren, much appreciated! :)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit ca4796b into kubernetes:master Nov 19, 2023
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 19, 2023
k8s-ci-robot added a commit that referenced this pull request Nov 20, 2023
…-upstream-release-1.28

Automated cherry pick of #16110: Update kube-router to v1.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants