Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added image minimum and maximum gc age #16318

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

Lerentis
Copy link
Contributor

@Lerentis Lerentis commented Feb 2, 2024

Copy link

linux-foundation-easycla bot commented Feb 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Lerentis / name: Tobias Trabelsi (311f402)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Lerentis!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Lerentis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 2, 2024
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @Lerentis. It looks good mostly.
Please use *string instead of string and re-run make apimachinery.

pkg/apis/kops/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/v1alpha2/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/v1alpha2/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/v1alpha3/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/v1alpha3/componentconfig.go Outdated Show resolved Hide resolved
@hakman
Copy link
Member

hakman commented Feb 3, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2024
Signed-off-by: Tobias Trabelsi <lerentis@uploadfilter24.eu>
@Lerentis
Copy link
Contributor Author

Lerentis commented Feb 3, 2024

Thanks for adding this @Lerentis. It looks good mostly. Please use *string instead of string and re-run make apimachinery.

Changed and rerun the generators accordingly 😃

@Lerentis Lerentis requested a review from hakman February 3, 2024 11:32
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lerentis! 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2024
k8s-ci-robot added a commit that referenced this pull request Feb 3, 2024
…-upstream-release-1.28

Automated cherry pick of #16318: added image minimum and maximum gc age
@k8s-ci-robot k8s-ci-robot merged commit 01705a6 into kubernetes:master Feb 3, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose imageMinimumGCAge and imageMaximumGCAge kubelet config
3 participants