-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added image minimum and maximum gc age #16318
Conversation
|
Welcome @Lerentis! |
Hi @Lerentis. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @Lerentis. It looks good mostly.
Please use *string
instead of string
and re-run make apimachinery
.
/ok-to-test |
Signed-off-by: Tobias Trabelsi <lerentis@uploadfilter24.eu>
Changed and rerun the generators accordingly 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Lerentis! 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.28 Automated cherry pick of #16318: added image minimum and maximum gc age
fixes #16317
i hope i added these correctly. tried to follow these docs: https://github.com/kubernetes/kops/blob/master/docs/contributing/api_updates.md#adding-a-field