Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick of #16403: aws: expose port 8443 when using NLB with a custom #16405

Conversation

hakman
Copy link
Member

@hakman hakman commented Mar 13, 2024

Cherry pick of #16403 on release-1.28.

#16403: aws: expose port 8443 when using NLB with a custom

For details on the cherry pick process, see the cherry pick requests page.


@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Mar 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2024
@k8s-ci-robot k8s-ci-robot requested a review from johngmyers March 13, 2024 06:11
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Mar 13, 2024
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus March 13, 2024 06:11
@hakman
Copy link
Member Author

hakman commented Mar 13, 2024

/cc @justinsb
/assign @justinsb

@k8s-ci-robot k8s-ci-robot requested a review from justinsb March 13, 2024 06:11
@hakman hakman force-pushed the automated-cherry-pick-of-#16403-upstream-release-1.28 branch from 68a768d to 79330c1 Compare March 13, 2024 06:26
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2024
justinsb and others added 2 commits March 13, 2024 08:31
We dropped the security group rules for this when moving to NLB
security groups; add them back.

Issue kubernetes#16024
@hakman hakman force-pushed the automated-cherry-pick-of-#16403-upstream-release-1.28 branch from 79330c1 to e296009 Compare March 13, 2024 06:40
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
@hakman hakman changed the title Automated cherry pick of #16403: aws: expose port 8443 when using NLB with a custom Cherry pick of #16403: aws: expose port 8443 when using NLB with a custom Mar 13, 2024
@justinsb
Copy link
Member

Thanks @hakman

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 17ac5e2 into kubernetes:release-1.28 Mar 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants