-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick of #16403: aws: expose port 8443 when using NLB with a custom #16405
Merged
k8s-ci-robot
merged 2 commits into
kubernetes:release-1.28
from
hakman:automated-cherry-pick-of-#16403-upstream-release-1.28
Mar 13, 2024
Merged
Cherry pick of #16403: aws: expose port 8443 when using NLB with a custom #16405
k8s-ci-robot
merged 2 commits into
kubernetes:release-1.28
from
hakman:automated-cherry-pick-of-#16403-upstream-release-1.28
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68a768d
to
79330c1
Compare
We dropped the security group rules for this when moving to NLB security groups; add them back. Issue kubernetes#16024
79330c1
to
e296009
Compare
Thanks @hakman /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/provider/aws
Issues or PRs related to aws provider
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/office-hours
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #16403 on release-1.28.
#16403: aws: expose port 8443 when using NLB with a custom
For details on the cherry pick process, see the cherry pick requests page.