Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update testdata to stop using alpha versions #16433

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

justinsb
Copy link
Member

  • chore: update testdata to stop using alpha versions
  • chore: update generated testdata

For released versions, we should stop "using" the alphas/release-candidates.
Updating after switching away from alphas/RCs.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2024
@justinsb
Copy link
Member Author

I'm setting us up here to store well-known artifact hashes by embedding them in the kops binary. Not strictly necessary, because we will fall back on unknown versions I think, but it does make the tests cleaner / faster.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2d04e0a into kubernetes:master Mar 29, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants