Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use embedded hashes for our well-known assets #16439

Merged
merged 2 commits into from
May 11, 2024
Merged

Use embedded hashes for our well-known assets #16439

merged 2 commits into from
May 11, 2024

Conversation

justinsb
Copy link
Member

  • Create assetdata
  • Use embedded hashes for our well-known assets

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab March 30, 2024 18:07
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 30, 2024
@justinsb justinsb force-pushed the store_hashes_for_assets branch 2 times, most recently from ff03d07 to 349849c Compare March 30, 2024 18:13
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2024
@justinsb justinsb force-pushed the store_hashes_for_assets branch from 349849c to 119730f Compare April 2, 2024 12:21
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2024
@justinsb justinsb force-pushed the store_hashes_for_assets branch from 119730f to c26edfd Compare April 2, 2024 12:36
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2024
@justinsb justinsb force-pushed the store_hashes_for_assets branch 2 times, most recently from 14c8e69 to 8805d9a Compare April 21, 2024 23:17
@justinsb justinsb added this to the v1.30 milestone May 9, 2024
justinsb added 2 commits May 9, 2024 10:27
@justinsb
Use embedded hashes for our well-known assets
fc049f4 
Rather than downloading the hash every time, we can record the hashes
for our well-known assets and bake them into the kOps binary.  If the
hash is not baked in, we will continue to fall-back to downloading it,
this is important for new k8s versions, or where the user specifies a
version of one of our well-known assets (such as containerd).
@justinsb
assets: add hashes for newest assets
4ab4ccf 
Some new releases, and the latest patch in each.
@justinsb justinsb force-pushed the store_hashes_for_assets branch from 8805d9a to 4ab4ccf Compare May 9, 2024 14:27
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 9, 2024
@justinsb justinsb changed the title WIP: Use embedded hashes for our well-known assets Use embedded hashes for our well-known assets May 11, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2024
hakman
hakman approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the logic from the initial PR got lost somewhere. If I recall correctly we were removing all the unused binaries and architectures. Though this is a nit, we can address it later.
Thanks! 😄

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 22eea4e into kubernetes:master May 11, 2024
21 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @hakman