Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #16572: Upgrade node-termination-handler to 1.22.0 #16595

Conversation

jim-barber-he
Copy link
Contributor

Cherry pick of #16572 on release-1.29.

#16572: Upgrade node-termination-handler to 1.22.0

For details on the cherry pick process, see the cherry pick requests page.


Also allow to specify the following extra parameters for it.
- deleteSqsMsgIfNodeNotFound
- memoryLimit
- podTerminationGracePeriod
- taintNode
- webhookTemplate

Signed-off-by: Jim Barber <jim.barber@healthengine.com.au>
Signed-off-by: Jim Barber <jim.barber@healthengine.com.au>
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone May 31, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jim-barber-he. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/addons labels May 31, 2024
@k8s-ci-robot k8s-ci-robot requested review from hakman and johngmyers May 31, 2024 01:39
@hakman
Copy link
Member

hakman commented May 31, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2024
@jim-barber-he
Copy link
Contributor Author

jim-barber-he commented May 31, 2024

@hakman To fix the tests do I just checkout out the automated-cherry-pick-of-#16572-upstream-release-1.29 branch and run the hack/update-expected.sh script to update everything?

EDIT: I've done this and pushed the result since it changes a lot of what the tests were complaining about.
I still have one failed test locally but not sure how to fix it

FAIL	k8s.io/kops/cmd/kops	600.099s

There was nothing else with the word fail in it. I found these things mentioning error

W0531 14:07:32.184899  284837 executor.go:141] error running task "Instance/control-plane-fr-par-1" (29s remaining to succeed): error opening resource: resource opened before it is ready (task=&{control-plane-fr-par-1 Sync 0xc001d29088 0xc001375808 0xc00170fef0 {<nil> 0xc001bb8d20} [0xc001bb8c80] map[apiserver-aggregator-ca:0xc000858180 etcd-clients-ca:0xc000859100 etcd-manager-ca-events:0xc000859980 etcd-manager-ca-main:0xc000859000 etcd-peers-ca-events:0xc000859a00 etcd-peers-ca-main:0xc000859080 kubernetes-ca:0xc000858100 service-account:0xc000858200] {<nil> 0xc001bb8d20}})
W0531 14:07:32.184916  284837 executor.go:141] error running task "Instance/nodes-fr-par-1" (29s remaining to succeed): error opening resource: resource opened before it is ready (task=&{nodes-fr-par-1 Sync 0xc001d29088 0xc001375c08 0xc00170fef0 {<nil> 0xc001bb8dc0} [0xc001bb8c80] map[etcd-clients-ca:0xc000859100 etcd-manager-ca-events:0xc000859980 etcd-manager-ca-main:0xc000859000 etcd-peers-ca-events:0xc000859a00 etcd-peers-ca-main:0xc000859080 kubernetes-ca:0xc000858100] {<nil> 0xc001bb8dc0}})

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5b8e06d into kubernetes:release-1.29 May 31, 2024
13 checks passed
@jim-barber-he jim-barber-he deleted the automated-cherry-pick-of-#16572-upstream-release-1.29 branch May 31, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants