-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #16572: Upgrade node-termination-handler to 1.22.0 #16595
Automated cherry pick of #16572: Upgrade node-termination-handler to 1.22.0 #16595
Conversation
Also allow to specify the following extra parameters for it. - deleteSqsMsgIfNodeNotFound - memoryLimit - podTerminationGracePeriod - taintNode - webhookTemplate Signed-off-by: Jim Barber <jim.barber@healthengine.com.au>
Signed-off-by: Jim Barber <jim.barber@healthengine.com.au>
Hi @jim-barber-he. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@hakman To fix the tests do I just checkout out the EDIT: I've done this and pushed the result since it changes a lot of what the tests were complaining about.
There was nothing else with the word
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #16572 on release-1.29.
#16572: Upgrade node-termination-handler to 1.22.0
For details on the cherry pick process, see the cherry pick requests page.