Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster-autoscaler priority expander config #16670

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

rifelpet
Copy link
Member

We were iterating over a map which has undefined ordering, resulting in inconsistent diffs to the manifest during kops update cluster. We now sort the instsance groups to ensure the rendered manifest remains consistent.

Closes #16664

We were iterating over a map which has undefined ordering, resulting in inconsistent diffs to the manifest during `kops update cluster`.
We now sort the instsance groups to ensure the rendered manifest remains consistent.
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 81bd83d into kubernetes:master Jul 14, 2024
21 checks passed
k8s-ci-robot added a commit that referenced this pull request Jul 14, 2024
…70-origin-release-1.30

Automated cherry pick of #16670: Fix cluster-autoscaler priority expander config
k8s-ci-robot added a commit that referenced this pull request Jul 14, 2024
…70-origin-release-1.29

Automated cherry pick of #16670: Fix cluster-autoscaler priority expander config
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jul 14, 2024
k8s-ci-robot added a commit that referenced this pull request Jul 17, 2024
…70-origin-release-1.28

Automated cherry pick of #16670: Fix cluster-autoscaler priority expander config
@rifelpet
Copy link
Member Author

/milestone v1.31

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster-autoscaler: priority-expander sort order always changing
3 participants