Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use latest K8s build for scale tests #16701

Merged
merged 1 commit into from
Jul 31, 2024
Merged

test: Use latest K8s build for scale tests #16701

merged 1 commit into from
Jul 31, 2024

Conversation

hakuna-matatah
Copy link
Contributor

Want to test 1.31.beta to see if it works on AWS.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2024
@k8s-ci-robot k8s-ci-robot requested review from hakman and olemarkus July 27, 2024 02:26
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

/retest

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

1 similar comment
@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakuna-matatah
Copy link
Contributor Author

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@rifelpet
Copy link
Member

/test presubmit-kops-aws-scale-amazonvpc-using-cl2
/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Jul 30, 2024

/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Jul 30, 2024

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakuna-matatah hakuna-matatah changed the title [WIP] Test 1.31 beta on AWS Test 1.31 beta on AWS Jul 30, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2024
@hakman hakman changed the title Test 1.31 beta on AWS test: Use latest K8s build for scale tests Jul 30, 2024
@hakman hakman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
@hakuna-matatah
Copy link
Contributor Author

cc: @dims @shyamjvs @BenTheElder

@dims
Copy link
Member

dims commented Jul 30, 2024

@hakuna-matatah next time we could add K8S_VERSION in the test-infra ci job definition too right?

@hakuna-matatah
Copy link
Contributor Author

@hakuna-matatah next time we could add K8S_VERSION in the test-infra ci job definition too right?

I think we could also facilitate that, but wondering why would we want to do that ? Do we want to run for many different versions ? Or just the latest ?

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@hakuna-matatah
Copy link
Contributor Author

Looks like test run succeeded but it looks like Prow job is stuck in running state - https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kops/16701/presubmit-kops-aws-scale-amazonvpc-using-cl2/1818245175466528768

@BenTheElder
Copy link
Member

Looks like test run succeeded but it looks like Prow job is stuck in running state - https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kops/16701/presubmit-kops-aws-scale-amazonvpc-using-cl2/1818245175466528768

that's probably kubernetes-sigs/prow#210

@k8s-ci-robot
Copy link
Contributor

@hakuna-matatah: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-kops-aws-scale-amazonvpc-using-cl2 edc1231 link true /test presubmit-kops-aws-scale-amazonvpc-using-cl2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@hakman hakman mentioned this pull request Jul 31, 2024
Merged
@hakman hakman closed this Jul 31, 2024
@hakman hakman reopened this Jul 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2984669 into kubernetes:master Jul 31, 2024
24 of 28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jul 31, 2024
@BenTheElder
Copy link
Member

I think we could also facilitate that, but wondering why would we want to do that ? Do we want to run for many different versions ? Or just the latest ?

it's also nice to be explicit in the job config, so we have more confidence that e.g. release-master-informing jobs actually run code from master, though we should always confirm by investigating the uploaded artifacts

rsafonseca pushed a commit to rsafonseca/kops that referenced this pull request Oct 24, 2024
@hakuna-matatah @rsafonseca
Test 1.31 beta on AWS (kubernetes#16701)
579d376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
7 participants
@hakuna-matatah @rifelpet @hakman @k8s-ci-robot @dims @k8s-triage-robot @BenTheElder