-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Service Account Issuer Migration doc #16711
Update Service Account Issuer Migration doc #16711
Conversation
Add procedure for using `additionalServiceAccountIssuers` which was added in kubernetes#16497.
Hi @elliotdobson. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Just one info here, we tried it on our side and it worked perfectly 👍 |
Hey @hakman, can you approve this please? |
Sorry for missing this @elliotdobson, thanks again! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Update Service Account Issuer Migration documentation to include
additionalServiceAccountIssuers
migration procedure. Follow up from #16541 now that I have tested the migration usingadditionalServiceAccountIssuers
.