Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Service Account Issuer Migration doc #16711

Merged

Conversation

elliotdobson
Copy link
Contributor

Update Service Account Issuer Migration documentation to include additionalServiceAccountIssuers migration procedure. Follow up from #16541 now that I have tested the migration using additionalServiceAccountIssuers.

Add procedure for using `additionalServiceAccountIssuers` which was added in kubernetes#16497.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @elliotdobson. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot requested a review from hakman July 30, 2024 23:12
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus July 30, 2024 23:12
@hakman
Copy link
Member

hakman commented Jul 31, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2024
@rasta-rocket
Copy link

Just one info here, we tried it on our side and it worked perfectly 👍
Thank you @elliotdobson

@elliotdobson
Copy link
Contributor Author

Hey @hakman, can you approve this please?

@hakman
Copy link
Member

hakman commented Oct 14, 2024

Sorry for missing this @elliotdobson, thanks again!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@hakman hakman closed this Oct 15, 2024
@hakman hakman reopened this Oct 15, 2024
@hakman
Copy link
Member

hakman commented Oct 15, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2e77e0c into kubernetes:master Oct 15, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants