Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify-golangci-lint #16746

Merged

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 9, 2024

Ref: #16744

running golangci-lint 
level=warning msg="[config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`."
cmd/kops/create_cluster_test.go:40:12: printf: non-constant format string in call to (*testing.common).Errorf (govet)
		t.Errorf(err.Error())
		         ^
pkg/k8scodecs/codecs_test.go:77:11: printf: non-constant format string in call to (*testing.common).Logf (govet)
			t.Logf(diff.FormatDiff(actual, expected))
			       ^
pkg/kopscodecs/codecs_test.go:71:11: printf: non-constant format string in call to (*testing.common).Logf (govet)
			t.Logf(diff.FormatDiff(actual, expected))
			       ^
pkg/kopscodecs/codecs_test.go:105:11: printf: non-constant format string in call to (*testing.common).Logf (govet)
			t.Logf(diff.FormatDiff(actual, g.expected))
			       ^
upup/pkg/fi/executor.go:130:20: printf: non-constant format string in call to k8s.io/klog/v2.Warningf (govet)
					klog.Warningf(err.Error())
					              ^
upup/pkg/fi/cloudup/gcetasks/instancetemplate.go:445:21: printf: non-constant format string in call to (k8s.io/klog/v2.Verbose).Infof (govet)
			klog.V(10).Infof(diff.FormatDiff(ls, rs))
			                 ^
upup/pkg/fi/cloudup/scaleway/utils.go:168:26: printf: non-constant format string in call to fmt.Errorf (govet)
		return nil, fmt.Errorf(errMsg)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2024
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/provider/scaleway Issues or PRs related to Scaleway provider labels Aug 9, 2024
@hakman
Copy link
Member Author

hakman commented Aug 9, 2024

/cc @justinsb @rifelpet

@hakman hakman force-pushed the dependencies/update-1723183478 branch from 9631f65 to 70b2f0c Compare August 9, 2024 17:38
@hakman hakman force-pushed the dependencies/update-1723183478 branch from 70b2f0c to 689462a Compare August 9, 2024 17:45
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2024
@hakman
Copy link
Member Author

hakman commented Aug 9, 2024

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2024
@justinsb
Copy link
Member

justinsb commented Aug 9, 2024

Thank you!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2b39cbe into kubernetes:master Aug 9, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Aug 9, 2024
@rifelpet
Copy link
Member

/milestone v1.31

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/provider/scaleway Issues or PRs related to Scaleway provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants