Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: create basic test for creating VMs on github actions #16784

Merged
merged 1 commit into from
Aug 29, 2024
Merged

tests: create basic test for creating VMs on github actions #16784

merged 1 commit into from
Aug 29, 2024

Conversation

justinsb
Copy link
Member

We try to bring up 3 VMs and SSH to them.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
@justinsb
Copy link
Member Author

/wip

@assign @hakman

I figure if we can run KVM/qemu on github actions, that would be a nice way to test. Still WIP because I need to hook this up to github actions!

@justinsb justinsb force-pushed the bare_metal_test_on_github_actions branch 8 times, most recently from ecc6e01 to 9497a20 Compare August 28, 2024 12:34
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
@justinsb justinsb force-pushed the bare_metal_test_on_github_actions branch 11 times, most recently from a0fc976 to 946ea0c Compare August 28, 2024 14:09
hakman
hakman reviewed Aug 28, 2024
View reviewed changes
.github/workflows/main.yml Outdated
@@ -80,3 +80,20 @@ jobs:
working-directory: ${{ env.GOPATH }}/src/k8s.io/kops
run: |
make quick-ci

tests-e2e-scenarios-bare-metal:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move the test to a different file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was debating it ... yes, I think it's a good idea! presubmits.yaml ? e2e.yaml ?

Copy link
Member

@hakman hakman Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e or bare-metal. We can always rename later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e works for me - thanks!

@justinsb justinsb force-pushed the bare_metal_test_on_github_actions branch from 946ea0c to 5d8ff34 Compare August 28, 2024 15:16
@justinsb
Copy link
Member Author

/retest

A few pod scheduling timeouts on prow, should not be related to this or even to kOps code..

@justinsb
tests: create basic test for creating VMs on github actions
fe66a14 
We try to bring up 3 VMs and SSH to them.
@justinsb justinsb force-pushed the bare_metal_test_on_github_actions branch from 5d8ff34 to fe66a14 Compare August 28, 2024 21:26
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2a71599 into kubernetes:master Aug 29, 2024
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @hakman